Update extension icon (and use a special preview icon) #3493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This aligns us with the icons used for PowerShell 7 and sufficiently differentiates the PowerShell, PowerShell Preview, and Azure PowerShell extensions on the marketplace.
ghost
added
|
@rjmholt do you have a way to test this? It seems like since the extensions already exist on the marketplace, at least on my Mac when I build and install the VSIX I see the old icon, but I check the package contents and manifest and they're correct. I also verified and like the Python extension's icon isn't square and is ~600 pixels wide PNG so the icon itself should be fine. |
No, but I think it should be ok |
rjmholt
approved these changes
Aug 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns us with the icons used for PowerShell 7 and sufficiently
differentiates the PowerShell, PowerShell Preview, and Azure PowerShell
extensions on the marketplace.
Resolves #3422.